Skip to content

Проверка типов с помощью PropTypes #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Feb 20, 2019
Merged

Проверка типов с помощью PropTypes #129

merged 26 commits into from
Feb 20, 2019

Conversation

vvscode
Copy link
Contributor

@vvscode vvscode commented Feb 14, 2019

No description provided.

@tesseralis tesseralis mentioned this pull request Feb 14, 2019
Closed
88 tasks
@another-guy another-guy added the needs review A pull request ready to be reviewed label Feb 14, 2019
angryermine
angryermine reviewed Feb 14, 2019
View reviewed changes
Copy link
Contributor

@angryermine angryermine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет! Во всех источниках, что я нашел, "по умолчанию" пишется без дефиса.

angryermine and others added 6 commits February 14, 2019 12:52
@angryermine @vvscode
Update content/docs/typechecking-with-proptypes.md
cea2850 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@angryermine @vvscode
Update content/docs/typechecking-with-proptypes.md
d477a7e 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@angryermine @vvscode
Update content/docs/typechecking-with-proptypes.md
fa3cdb5 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@angryermine @vvscode
Update content/docs/typechecking-with-proptypes.md
36aa870 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@angryermine @vvscode
Update content/docs/typechecking-with-proptypes.md
26fe782 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@angryermine @vvscode
Update content/docs/typechecking-with-proptypes.md
bc08962 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
lex111
lex111 reviewed Feb 14, 2019
View reviewed changes
lex111 and others added 11 commits February 14, 2019 20:17
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
eda2c74 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
56c6721 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
a3adcef 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
247b333 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
f3dfab8 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
3d7221b 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
33af50a 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
736b825 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
a5e16f9 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
bac38ff 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
d82b464 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
ntishkevich
ntishkevich reviewed Feb 14, 2019
View reviewed changes
ntishkevich and others added 5 commits February 15, 2019 08:09
@ntishkevich @vvscode
Update content/docs/typechecking-with-proptypes.md
52567f5 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@ntishkevich @vvscode
Update content/docs/typechecking-with-proptypes.md
fde8f7a 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@ntishkevich @vvscode
Update content/docs/typechecking-with-proptypes.md
1a6f305 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@vvscode
props -> пропсы
4eff932
@lex111 @vvscode
Update content/docs/typechecking-with-proptypes.md
7d69431 
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111 lex111 requested a review from another-guy February 15, 2019 05:19
another-guy
another-guy approved these changes Feb 20, 2019
View reviewed changes
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень недурно! У меня только одно предложение по тексту.

Спасибо, @vvscode ! 🎉

@another-guy another-guy removed their assignment Feb 20, 2019
@lex111 lex111 merged commit 69c7a4d into reactjs:master Feb 20, 2019
@lex111
Copy link
Member

lex111 commented Feb 20, 2019

@vvscode спасибо, а также @lfedorov, @gcor, @ntishkevich и @another-guy за ревью!

@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angryermine angryermine angryermine left review comments

@lex111 lex111 lex111 approved these changes

@gcor gcor gcor left review comments

@ntishkevich ntishkevich ntishkevich left review comments

@another-guy another-guy another-guy approved these changes

Assignees
No one assigned
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vvscode @lex111 @angryermine @gcor @another-guy @ntishkevich